fix: React Doctor audit - fix errors and accessibility warnings#44
Merged
fix: React Doctor audit - fix errors and accessibility warnings#44
Conversation
React Doctor (react-doctor@0.0.28) audit of the codebase. Fixes applied: Errors fixed: - SessionName.tsx: Remove derived state useEffect, sync editValue in click handler - XYPad.tsx: Add missing aria-valuemin/max/now on role="slider" Warnings fixed: - BottomSheet.tsx: Add role="dialog" and aria-modal to backdrop - ToastNotification.tsx: Add role="button", tabIndex, keyboard handler to URL toast - LandingPage.tsx: Add role="button", tabIndex, keyboard handler to example cards - TrackRow.tsx: Add keyboard handler to mobile edit panel - TransportBar.tsx: Add role="slider" with aria props to tempo/swing controls - Waveform.tsx: Add role="img", extract default prop to module constant - EffectsPanel.tsx: Add htmlFor/id to all label/input pairs (10 controls) - Transport.tsx: Add htmlFor/id to all label/input pairs (10 controls) - MixerPanel.tsx: Add htmlFor/id to swing label/input pair - PitchOverview.tsx: Remove unnecessary useMemo on visibleTrackCount - StepSequencer.tsx: Remove unnecessary useMemo on mutedTrackCount - QRCode.tsx: Consolidate multiple setState calls into single state object Remaining items are false positives or architectural (large components, etc). https://claude.ai/code/session_01QtahFXjazAx1yD9qQdUyGM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Doctor (react-doctor@0.0.28) audit of the codebase. Fixes applied:
Errors fixed:
Warnings fixed:
Remaining items are false positives or architectural (large components, etc).
https://claude.ai/code/session_01QtahFXjazAx1yD9qQdUyGM